[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 2/4] interface: avoid memory leak on parse error



Detected by Coverity.  Unlikely to hit unless the file contents
were corrupted.

* src/util/interface.c (ifaceRestoreMacAddress): Plug leak.
---
 src/util/interface.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/util/interface.c b/src/util/interface.c
index d51ceec..f486124 100644
--- a/src/util/interface.c
+++ b/src/util/interface.c
@@ -1,6 +1,7 @@
 /*
  * interface.c: interface support functions
  *
+ * Copyright (C) 2011 Red Hat, Inc.
  * Copyright (C) 2010 IBM Corp.
  * Copyright (C) 2010 Stefan Berger
  *
@@ -1100,6 +1101,7 @@ ifaceRestoreMacAddress(const char *linkdev,
         ifaceError(VIR_ERR_INTERNAL_ERROR,
                    _("Cannot parse MAC address from '%s'"),
                    oldmacname);
+        VIR_FREE(macstr);
         return -1;
     }

-- 
1.7.4.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]