[libvirt] [libvirt-snmp][PATCH] Another cleanup
Daniel P. Berrange
berrange at redhat.com
Thu Mar 3 11:52:33 UTC 2011
On Thu, Mar 03, 2011 at 11:50:01AM +0100, Michal Privoznik wrote:
> ---
> With respect to hints given in package review process:
> https://bugzilla.redhat.com/show_bug.cgi?id=681558
> diff --git a/libvirt-snmp.spec.in b/libvirt-snmp.spec.in
> index ed93e75..0591aa3 100644
> --- a/libvirt-snmp.spec.in
> +++ b/libvirt-snmp.spec.in
> @@ -1,6 +1,6 @@
> Name: libvirt-snmp
> Version: @VERSION@
> -Release: 1%{?dist}%{?extra_release}
> +Release: 1%{?dist}
NACK to removing this bit. It is there for performing automated
builds and for people who want to rebuild the Fedora RPM and
append a unique string to the release to identify their rebuild.
All our virt related RPMs in Fedora have this so reject that
review comment in BZ.
>
> %changelog
> -* Thu Feb 2 2011 Michal Privoznik <mprivozn at redhat.com> 0.0.1-1%{?dist}%{?extra_release}
> +* Thu Feb 2 2011 Michal Privoznik <mprivozn at redhat.com> 0.0.1-1%{?dist}
You should always leave %{dist} and %{?extra_release} out of the
changelog entries completely, because it will cause merge conflicts
when cherry picking changes across Fedora release branches. Just
use '0.0.1-1'
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list