[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/5] libvirt/qemu - allow modification of devices in inactive domain



On 03/03/2011 04:40 PM, KAMEZAWA Hiroyuki wrote:
> On Thu, 3 Mar 2011 10:07:40 +0900
> KAMEZAWA Hiroyuki <kamezawa hiroyu jp fujitsu com> wrote:
> 
>>
>> Now, Xen supports at(de)tach-disk, at(de)tach-interface for inactive domains
>> with --perisitent option. (Using --persisten against live domain will
>> cause error.)
>>
>> Now, virsh attach-xxx/detach-xxx cannot modify inactive domains in qemu and
>> --persistent option just returns error.
>>
>> This series adds support for modification of inactive domain's disk, interfaces.
>>
>> Short description
>>  1 ... clean up for Xen's driver
>>  2 ... add my name to AUTHORS
>>  3 ... add --persistent modification support, just a wrapper function. 
>>  4 ... add disk support
>>  5 ... add nics support
>>
> 
> What's bad with this patches ?

Personally, I think they are a good addition, but I haven't yet had time
to review them closely for potential coding gotchas.  Rest assured, it's
on my todo list, and either these patches, or a further refined version,
will be included in the next libvirt release.

> 
> If libvirt never supports modification of XML in virsh *** command,
> I'll change my direction and send patches to virtinst.

Sorry for the delays; it's been a busy week (I've been swamped trying to
debug libvirt crashes, which takes a higher priority on my plate over
libvirt feature additions).  Don't give up yet; and it's fine to ping us
every few days if we continue to drag our feet!

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]