[libvirt] [PATCHv3 06/10] storage: simplify fd handling

Paolo Bonzini pbonzini at redhat.com
Fri Mar 4 08:15:09 UTC 2011


On 03/04/2011 01:37 AM, Eric Blake wrote:
> -                           unsigned int flags ATTRIBUTE_UNUSED)
> +                           unsigned int flags)

Uhm, you're still not using the flags, you're just using the argument as 
a place to write the flags for virFileOperation.  Perhaps the "inner" 
flags variable should be renamed?

Paolo




More information about the libvir-list mailing list