[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Gives a warning when unable to create cgroup for qemu.



On Fri, Mar 04, 2011 at 12:05:59PM +0800, Hu Tao wrote:
> 
> Signed-off-by: Hu Tao <hutao cn fujitsu com>
> ---
>  src/qemu/qemu_driver.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index c9095bb..a54bfc5 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -520,7 +520,7 @@ qemudStartup(int privileged) {
>      rc = virCgroupForDriver("qemu", &qemu_driver->cgroup, privileged, 1);
>      if (rc < 0) {
>          char buf[1024];
> -        VIR_INFO("Unable to create cgroup for driver: %s",
> +        VIR_WARN("Unable to create cgroup for driver: %s",
>                   virStrerror(-rc, buf, sizeof(buf)));
>      }

NACK, this is reverting the change we just made

  commit eacb3bb02a66c69fda8ec20672cf2ae24aae49bd
  Author: Daniel P. Berrange <berrange redhat com>
  Date:   Thu Feb 10 10:47:46 2011 +0000

    Reduce log level when cgroups aren't mounted
    
    Quite a few hosts don't have cgroups mounted and so see warnings
    from libvirt logged, which then cause bug reports, etc. Reduce
    the log level to INFO so they're not visible by default

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]