[libvirt] [PATCH] virsh: fix memtune's help message for swap_hard_limit

Nikunj A. Dadhania nikunj at linux.vnet.ibm.com
Mon Mar 7 09:41:12 UTC 2011


On Fri, 4 Mar 2011 14:46:12 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu at jp.fujitsu.com> wrote:
> On Thu, 03 Mar 2011 14:47:36 +0800
> Osier Yang <jyang at redhat.com> wrote:
> > > Yes, I think it's better. Should I prepare patches ? or you'll do ?
> > 
> > Let's see other guys's opinions before doing it, :)
> > 
> 
> A patch (full change version) is here. maybe good input for discussion.
> 
> ==
> >From 0bceb6f204f7551c701d9f60fecd82562b38bd50 Mon Sep 17 00:00:00 2001
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu at jp.fujitsu.com>
> Date: Fri, 4 Mar 2011 14:46:08 +0900
> Subject: [PATCH] Rename swap_hard_limit as memswap_hard_limit
> 
> This patch affects qemu and lxc, using memory cgroup.
> 
> Linux's memory cgroup's memory.memsw.limit_in_bytes is a limit
> for memory+swap, not for swap.
> (This behavior is for avoiding bad influence for global vmscan
>  and never disturb kswapd behavior by user's setting.)
> 
Argh, thats me... :(
Thanks for the patch Kame.

Reviewed-by: "Nikunj A. Dadhania" <nikunj at linux.vnet.ibm.com>

Regards,
Nikunj




More information about the libvir-list mailing list