[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix building error when building without libvirtd



On 03/08/2011 08:18 PM, Wen Congyang wrote:
> Yes, we should provide libvird.8.in in tarball.
> 
>>
>> Instead, does this fix your problem?
> No, the building is still broken. We should move POD2MAN outside of the
> WITH_LIBVIRTD conditional too.

Obvious, if I'd stopped to think about it :)  My testing revealed the same.

> 
>>From 7cffdd4ce7c2aec15254bd0c701d0a819333bc00 Mon Sep 17 00:00:00 2001
> From: Wen Congyang <wency cn fujitsu com>
> Date: Wed, 9 Mar 2011 11:16:26 +0800
> Subject: [PATCH] build: fix building error when building without libvirtd
> 
> Signed-off-by: Wen Congyang <wency cn fujitsu com>
> Signed-off-by: Eric Blake <eblake redhat com>
> 
> ---
>  daemon/Makefile.am |   13 +++++++------
>  1 files changed, 7 insertions(+), 6 deletions(-)

ACK, and pushed.

>  
> +# This is needed for 'make dist' too, so can't wrap in WITH_LIBVIRTD.
> +POD2MAN = pod2man -c "Virtualization Support" \
> +			-r "$(PACKAGE)-$(VERSION)" -s 8
> +
> +$(srcdir)/libvirtd.8.in: libvirtd.pod.in
> +	$(AM_V_GEN)$(POD2MAN) $< $@
> +
>  # This is needed for clients too, so can't wrap in
>  # the WITH_LIBVIRTD conditional
>  if HAVE_SASL

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]