[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] security: ignore disk opening failure of DAC driver.



On Wed, Mar 09, 2011 at 04:39:01PM +0800, Osier Yang wrote:
> Which blocks the domain booting up if one of the disks
> can't be opened (e.g. doesn't exist).
> ---
>  src/security/security_dac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/security/security_dac.c b/src/security/security_dac.c
> index fba2d1d..8bb5bc9 100644
> --- a/src/security/security_dac.c
> +++ b/src/security/security_dac.c
> @@ -182,7 +182,7 @@ virSecurityDACSetSecurityImageLabel(virSecurityManagerPtr mgr,
> 
>      return virDomainDiskDefForeachPath(disk,
>                                         virSecurityManagerGetAllowDiskFormatProbing(mgr),
> -                                       false,
> +                                       true,
>                                         virSecurityDACSetSecurityFileLabel,
>                                         mgr);
>  }

NACK, if one the dynamic ownership is enabled, then this
failure is correct. If we can't relabel the file then
QEMU won't boot up anyway.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]