[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Include stdint.h in libvirt.h for INT64_MAX



On 03/09/2011 06:47 AM, Daniel Veillard wrote:
>> Instead of including stdint.h specify the value directly.
>> ---
>>  include/libvirt/libvirt.h.in |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
>> index 618b350..82e45d7 100644
>> --- a/include/libvirt/libvirt.h.in
>> +++ b/include/libvirt/libvirt.h.in
>> @@ -705,7 +705,7 @@ typedef enum {
>>   * Macro providing the virMemoryParameter value that indicates "unlimited"
>>   */
>>  
>> -#define VIR_DOMAIN_MEMORY_PARAM_UNLIMITED (INT64_MAX >> 10)
>> +#define VIR_DOMAIN_MEMORY_PARAM_UNLIMITED 9007199254740991 /* = INT64_MAX >> 10 */
> 
>   Hum shouldn't that be 9007199254740991UL to provide type information ?

UL still won't work on 32-bit platforms.  You need the LL (or ULL) suffix.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]