[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 7/8] audit: also audit cgroup ACL permissions



On Tue, Mar 08, 2011 at 10:13:49PM -0700, Eric Blake wrote:
> * src/qemu/qemu_audit.h (qemuAuditCgroupMajor)
> (qemuAuditCgroupPath): Add parameter.
> * src/qemu/qemu_audit.c (qemuAuditCgroupMajor)
> (qemuAuditCgroupPath): Add 'acl=rwm' to cgroup audit entries.
> * src/qemu/qemu_cgroup.c: Update clients.
> * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Likewise.
> ---
> 
> v2: new patch; perhaps patch should be floated before patch 2, and
> then this patch squashed into patch 2, so that I'm only touching
> qemuAuditCgroupPath once?

I don't think it hugely matters.

>  src/qemu/qemu_audit.c  |   12 ++++++++----
>  src/qemu/qemu_audit.h  |    2 ++
>  src/qemu/qemu_cgroup.c |   15 ++++++++-------
>  src/qemu/qemu_driver.c |    6 +++---
>  4 files changed, 21 insertions(+), 14 deletions(-)

ACK, unless it needs some changes based on my two comments to
the previous patch about certain RWM vs RW usage.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]