[libvirt] [PATCHv2 2/8] audit: split cgroup audit types to allow more information
Eric Blake
eblake at redhat.com
Wed Mar 9 16:01:40 UTC 2011
On 03/09/2011 08:07 AM, Daniel P. Berrange wrote:
> Rather than have the two strdup("rdev=?") calls, I reckon it
> would be better to just return NULL. Then the caller can just
> check for NULL itself & fallback to a static "rdev=?".
>
> In fact, perhaps this should just do
>
> virAsprintf(&ret, "%02X:%02X", maj, min);
>
> And...
>
>> + if (!(detail = virAuditEncode("path", path)) ||
>> + !(rdev = qemuAuditGetRdev(path)) ||
>> + virAsprintf(&extra, "path path=%s %s", path, rdev) < 0) {
>
> ...here do
>
> virAsprintf(&extra, "path path=%s rdev=%s", path, VIR_AUDIT_STR(rdev)) < 0) {
>
Yeah, that's nicer. Will do.
> ACK, to the rest of the patch though.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110309/3da602d2/attachment-0001.sig>
More information about the libvir-list
mailing list