[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 3/5] qemu: Rename qemuMonitorCommandWithHandler as qemuMonitorText*



On Thu, Mar 10, 2011 at 10:05:57AM +0100, Jiri Denemark wrote:
> qemu driver in libvirt gained support for creating domain snapshots
> almost a year ago in libvirt 0.8.0. Since then we enabled QMP support
> for qemu >= 0.13.0 but QMP equivalents of {save,load,del}vm commands are
> not implemented in current qemu (0.14.0) so the domain snapshot support
> is not very useful.
> 
> This patch detects when the appropriate QMP command is not implemented
> and tries to use human-monitor-command (aka HMP passthrough) to run
> it's HMP equivalent.
> ---
> Version 3:
> - separated from HMP passthrough infrastructure
> - implement HMP fallback for {load,del}vm in addition to savevm
> 
>  src/qemu/qemu_monitor_json.c |   40 +++++++++++++++++++++++++++++++---------
>  1 files changed, 31 insertions(+), 9 deletions(-)

ACK, but you need to fix the patch subject line when pushing

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]