[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 02/15] qemu: consolidate duplicated monitor migration code



On Wed, Mar 09, 2011 at 06:45:42PM -0700, Eric Blake wrote:
> * src/qemu/qemu_monitor_text.h (qemuMonitorTextMigrate): Declare
> in place of individual monitor commands.
> * src/qemu/qemu_monitor_json.h (qemuMonitorJSONMigrate): Likewise.
> * src/qemu/qemu_monitor_text.c (qemuMonitorTextMigrateToHost)
> (qemuMonitorTextMigrateToCommand, qemuMonitorTextMigrateToFile)
> (qemuMonitorTextMigrateToUnix): Delete.
> * src/qemu/qemu_monitor_json.c (qemuMonitorJSONMigrateToHost)
> (qemuMonitorJSONMigrateToCommand, qemuMonitorJSONMigrateToFile)
> (qemuMonitorJSONMigrateToUnix): Delete.
> * src/qemu/qemu_monitor.c (qemuMonitorMigrateToHost)
> (qemuMonitorMigrateToCommand, qemuMonitorMigrateToFile)
> (qemuMonitorMigrateToUnix): Consolidate shared code.
> ---
>  src/qemu/qemu_monitor.c      |   92 +++++++++++++++++++++++++++----
>  src/qemu/qemu_monitor_json.c |  125 +----------------------------------------
>  src/qemu/qemu_monitor_json.h |   23 +------
>  src/qemu/qemu_monitor_text.c |  123 +----------------------------------------
>  src/qemu/qemu_monitor_text.h |   23 +------
>  5 files changed, 97 insertions(+), 289 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]