[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 09/15] util: rename virFileOperation to virFileOpenAs



On Wed, Mar 09, 2011 at 06:45:49PM -0700, Eric Blake wrote:
> This patch intentionally doesn't change indentation, in order to
> make it easier to review the real changes.

More importantly it removes the hook function now.

> 
> * src/util/util.h (VIR_FILE_OP_RETURN_FD, virFileOperationHook):
> Delete.
> (virFileOperation): Rename...
> (virFileOpenAs): ...and reduce parameters.
> * src/util/util.c (virFileOperationNoFork, virFileOperation):
> Rename and simplify.
> * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Adjust caller.
> * src/storage/storage_backend.c (virStorageBackendCreateRaw):
> Likewise.
> * src/libvirt_private.syms: Reflect rename.
> ---
>  src/libvirt_private.syms      |    2 +-
>  src/qemu/qemu_driver.c        |   20 +++-----
>  src/storage/storage_backend.c |   12 ++--
>  src/util/util.c               |  103 +++++++++++++----------------------------
>  src/util/util.h               |   15 ++----
>  5 files changed, 53 insertions(+), 99 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]