[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] setmem: introduce a new libvirt API (virDomainSetMemoryFlags)



On 03/02/2011 01:07 AM, Taku Izumi wrote:
> 
> This patch introduces a new libvirt API (virDomainSetMemoryFlags) and
> a flag (virDomainMemoryModFlags).
> 

> +/* Memory size modification flags. */
> +typedef enum {
> +    VIR_DOMAIN_MEM_LIVE   = (1 << 0), /* affect active domain */
> +    VIR_DOMAIN_MEM_CONFIG = (1 << 1), /* affect next boot */
> +} virDomainMemoryModFlags;

Here called virDomainMemoryModFlags, because virDomainMemoryFlags was
already taken,


> +/*
> + * virDomainSetMemoryFlags
> + * @domain: a domain object or NULL
> + * @memory: the memory size in kilobytes
> + * @flags: an OR'ed set of virDomainMemoryFlags

But here just virDomainMemoryFlags.  I've fixed the typo, adjust
libvirt_public.syms, added you to AUTHORS (let me know if you want to
adjust how your name appears - for now I just copied your Signed-Off-By
spelling), and squashed in patch 2/5 (with more amendments - see my
reply there), then pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]