[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/5] setmem: implement the remote protocol to address the new API



On 03/02/2011 01:13 AM, Taku Izumi wrote:
> 
> This patch implements the remote protocol to address the new API.
> 
> Index: libvirt-git/src/remote/remote_driver.c
> ===================================================================
> --- libvirt-git.orig/src/remote/remote_driver.c
> +++ libvirt-git/src/remote/remote_driver.c
> @@ -2445,6 +2445,33 @@ done:
>  }
> 
>  static int
> +remoteDomainSetMemoryFlags (virDomainPtr domain, unsigned long memory, unsigned int
> flags)

The extra newline here caused git to complain that your patch was
corrupt.  You had several other cases where the patch was botched.

After fixing those, the patch still failed indentation in
remote_protocol-structs.  (Hmm - why do we create that file with TABs in
the first place? I should fix that in a followup)

> Index: libvirt-git/src/remote_protocol-structs
> ===================================================================
> --- libvirt-git.orig/src/remote_protocol-structs
> +++ libvirt-git/src/remote_protocol-structs
> @@ -340,6 +340,11 @@ struct remote_domain_set_memory_args {
>  	remote_nonnull_domain      dom;
>  	uint64_t                   memory;
>  };
> +struct remote_domain_set_memory_flags_args {
> +        remote_nonnull_domain      dom;
> +        uint64_t                   memory;
> +        u_int                      flags;
> +};

Plus, when I reran rpcgen, it changed the spacing in remote_protocol.c.

I pushed after fixing those issues.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]