[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] domain.rng vs. formatdomain.html#elementsUSB



Hello Daniel, hello Eric,

Ping?

Am Dienstag 01 März 2011 11:23:20 schrieb Philipp Hahn:
> The Relax-NG schema for domains regarding <hostdev> doesn't match what's
> implemented in src/conf/domain_conf.c#virDomainHostdevDefFormat(): The
> implementation only requires @type, but the schema currently either
> required none or all three attributes (@mode, @type, and @managed) to be
> defined together, because they are declared in the same
> <optional)-section. (@managed is currently even undocumented on
> <http://libvirt.org/formatdomain.html#elementsUSB>).
>
> Thus the following minimal <hostdev>-example fails to validate:
> <domain type='test'>
>         <name>N</name>
>         <memory>4096</memory>
>         <bootloader>/bin/false</bootloader>
>         <os>
>                 <type arch='x86_64' machine='xenpv'>linux</type>
>         </os>
>         <devices>
>                 <hostdev type='pci'>
>                         <source>
>                                 <address bus='0x06' slot='0x00'
> function='0x0'/> </source>
>                 </hostdev>
>         </devices>
> </domain>
>
> The schema is changed to match the current implementation:
> 1. @mode is optional (which defaults to 'subsystem')
> 2. @type is required
> 3. @managed is optional (which defaults to 'no')
>
> The documnetation is updated to mention @managed.

What some more changes or how may I improve my contrinbution?

Sincerely
Philipp
-- 
Philipp Hahn           Open Source Software Engineer      hahn univention de
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  28359 Bremen                   fax: +49 421 22 232-99
                                                   http://www.univention.de/

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]