[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] RFC: support "vram" and "heads" for qxl vga



On 02/15/2011 06:47 AM, Osier Yang wrote:
> qemu command line to specify "vram":
>     -global qxl.vram_size=uint
> 
> +                if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_QXL) {
> +                    if (def->videos[0]->vram &&
> +                        (qemuCmdFlags & QEMUD_CMD_FLAG_GLOBAL)) {
> +                        virCommandAddArgFormat(cmd, "-global qxl.vram_size=%u",
> +                                               def->videos[0]->vram);
> +                    }

Ouch - this needs to be two arguments:

"-global", "qxl.vram_size=%u".

> +
> +                    if (def->videos[0]->heads > 0) {
> +                        for (i = 0; i < def->videos[0]->heads - 1; i++) {
> +                            virCommandAddArgFormat(cmd, "-device %s,id=qxl-%d", vgastr, i+1);

Likewise.  I'm preparing a patch (having just hit the issue when trying
to start a guest with a qxl graphics device).

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]