[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: fix -global argument usage



于 2011年03月12日 01:14, Eric Blake 写道:
> On 03/11/2011 10:10 AM, Daniel P. Berrange wrote:
>> On Fri, Mar 11, 2011 at 10:05:02AM -0700, Eric Blake wrote:
>>> * src/qemu/qemu_command.c (qemuBuildCommandLine): Pass two
>>> separate arguments, and fix indentation.
>>> ---
>>>
>>> I debated about pushing under the trivial rule, but restrained myself.
>>>
>>>   src/qemu/qemu_command.c |   13 +++++++------
>>>   1 files changed, 7 insertions(+), 6 deletions(-)
>>>
>>> +                        virCommandAddArg(cmd, "-global");
>>> +                        if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QXL_VGA))
>>> +                            virCommandAddArgFormat(cmd, "qxl-vga.vram_size=%u",
>>> +                                                   def->videos[0]->vram * 1024);
>>> +                        else
>>> +                            virCommandAddArgFormat(cmd, "qxl.vram_size=%u",
>>> +                                                   def->videos[0]->vram * 1024);
>>>                       }
>>
>> ACK
> 
> Thanks; pushed.

Thanks for fixing this, Eric. :-)

Regards
Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]