[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libvirt-guests: avoid globbing when splitting $URIS



Hello Eric,

Am Freitag 11 März 2011 22:08:33 schrieb Eric Blake:
> * tools/libvirt-guests.init.sh (start, stop, gueststatus): Avoid
> shell globbing, since valid URIs can contain '?'.

Looks sane, but perhaps setting 'set -f' once at the top of the file with some 
comment would fix the problem as well, but that's just a question of 
personally preferred style.

Sincerely
Philipp Hahn
-- 
Philipp Hahn           Open Source Software Engineer      hahn univention de
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]