[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Allow starting domains by UUID



On Fri, Mar 11, 2011 at 10:48:07 -0700, Eric Blake wrote:
> On 03/11/2011 04:15 AM, Jiri Denemark wrote:
> > diff --git a/tools/virsh.c b/tools/virsh.c
> > index a5e9c4f..b42aac4 100644
> > --- a/tools/virsh.c
> > +++ b/tools/virsh.c
> > @@ -1402,7 +1402,8 @@ cmdStart(vshControl *ctl, const vshCmd *cmd)
> >      if (!vshConnectionUsability(ctl, ctl->conn))
> >          return FALSE;
> >  
> > -    if (!(dom = vshCommandOptDomainBy(ctl, cmd, NULL, VSH_BYNAME)))
> > +    if (!(dom = vshCommandOptDomainBy(ctl, cmd, NULL,
> > +                                      VSH_BYNAME | VSH_BYUUID)))
> 
> ACK.  How many more of these might we be missing, due to copy-and-paste?

None, I reviewed all of them. It's mainly because most of virsh commands use a
convenient macro vshCommandOptDomain which searches by name, uuid, and id.

Pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]