[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: simplify PCI configfd handling in monitor



On 03/15/2011 06:19 PM, Chris Wright wrote:
> * Eric Blake (eblake redhat com) wrote:
>> @@ -829,21 +829,19 @@ int qemuDomainAttachHostPciDevice(struct qemud_driver *driver,
>>          if (qemuDomainPCIAddressEnsureAddr(priv->pciaddrs, &hostdev->info) < 0)
>>              goto error;
>>          if (qemuCapsGet(qemuCaps, QEMU_CAPS_PCI_CONFIGFD)) {
>> -            configfd = qemuOpenPCIConfig(hostdev);
>> +            if (priv->monConfig->type != VIR_DOMAIN_CHR_TYPE_UNIX) {
>> +                qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>> +                                _("pci configfd file cannot be attached: "
>> +                                  "qemu is not using a unix socket monitor"));
> 
> Should that be in common sendfd code?

Yeah, factoring that into a common location _would_ be nicer.  I'll whip
up a patch.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]