[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remote: Add missing virCondDestroy calls



On 03/17/2011 10:52 AM, Matthias Bolte wrote:
> The virCond of the remote_thread_call struct was leaked in some
> places. This results in leaking the underlying mutex. Which in turn
> leaks a handle on Windows.
> 
> Reported by Aliaksandr Chabatar and Ihar Smertsin.
> ---
> 
> See https://www.redhat.com/archives/libvir-list/2011-March/msg00789.html
> for the report.
> 
>  src/remote/remote_driver.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index 82e094b..8aa8801 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -8609,6 +8609,7 @@ remoteStreamPacket(virStreamPtr st,
>      xdr_destroy (&xdr);
> 
>      ret = remoteIO(st->conn, priv, 0, thiscall);
> +    ignore_value(virCondDestroy(&thiscall->cond));
>      VIR_FREE(thiscall);

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]