[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Detect support for HMP passthrough



On 03/17/2011 09:00 AM, Jiri Denemark wrote:
> ---
>  src/qemu/qemu_monitor.c      |   14 ++++++++++++--
>  src/qemu/qemu_monitor.h      |    2 ++
>  src/qemu/qemu_monitor_json.c |   42 ++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor_json.h |    2 ++
>  4 files changed, 58 insertions(+), 2 deletions(-)
> 

> +++ b/src/qemu/qemu_monitor.h
> @@ -127,6 +127,8 @@ void qemuMonitorClose(qemuMonitorPtr mon);
>  
>  int qemuMonitorSetCapabilities(qemuMonitorPtr mon);
>  
> +int qemuMonitorCheckHMP(qemuMonitorPtr mon);
> +

Do we need code in qemu_driver.c:qemuDomainMonitorCommand to make 'virsh
qemu-monitor-command --hmp' get a nice error message when
qemuMonitorCheckHMP fails, or is that error message already sufficient?

Depending on the answer to that question, ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]