[libvirt] [PATCH] Make virDomainObjParseNode() static
Eric Blake
eblake at redhat.com
Thu Mar 17 23:00:01 UTC 2011
On 03/16/2011 01:03 AM, Hu Tao wrote:
> Make virDomainObjParseNode() static since it is called only
> in one file.
> ---
> src/conf/domain_conf.c | 38 ++++++++++++++++++++------------------
> src/conf/domain_conf.h | 3 ---
> 2 files changed, 20 insertions(+), 21 deletions(-)
That seemed like a lot of churn, until I realized:
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 16e1291..c637300 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -6081,24 +6081,10 @@ cleanup:
> }
>
>
> -virDomainObjPtr virDomainObjParseFile(virCapsPtr caps,
> - const char *filename)
Oh, you also did code motion in the same patch, moving this function
down (or the other one up - diff can't quite tell the difference) to
preserve topological use.
ACK and pushed.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110317/30dc936a/attachment-0001.sig>
More information about the libvir-list
mailing list