[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] Add vim configuration that makes vim auto-indent code



On 03/16/2011 08:35 PM, Hu Tao wrote:
> ---
>  .gitignore           |    1 +
>  docs/hacking.html.in |   25 +++++++++++++++++++++++++
>  2 files changed, 26 insertions(+), 0 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 41f7654..197b4df 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -65,3 +65,4 @@ results.log
>  stamp-h
>  stamp-h.in
>  stamp-h1
> +.lvimrc

Sure, making it globally ignored works for me.  But rerunning
./autogen.sh sorts on your behalf (next to .git-module-status), so I had
to modify the commit..

> diff --git a/docs/hacking.html.in b/docs/hacking.html.in
> index 0d81b0b..6093fc6 100644
> --- a/docs/hacking.html.in
> +++ b/docs/hacking.html.in

HACKING is generated; rerunning 'make' picked up those changes for me
(if it didn't for you, then you are missing some prerequisite for
converting xml to plain text; it's not fatal to the build, but does
matter for things like this patch).

> @@ -101,6 +101,31 @@
>                              (libvirt-c-mode))))
>  </pre>
>  
> +    <p>
> +      If you use vim, append the following to your ~/.vimrc file:
> +    </p>


> +    <p>
> +      Or if you don't want to mess your ~/.vimrc up, you can save the above
> +      into a file called .lvimrc(not .vimrc) located at the root of libvirt

s/.lvimrc(not/.lvimrc (not)/

> +      source, then install a vim script from http://www.vim.org/scripts/script.php?script_id=1408,
> +      It

", It" should have been ". It" or ", which"; I went with the latter.

Can't say whether the content is accurate, but I'm assuming so.  Therefore,

ACK, and modified patch pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]