[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: respect locking rules



On 03/18/2011 12:11 PM, Daniel P. Berrange wrote:
> On Mon, Mar 14, 2011 at 08:38:09PM -0600, Eric Blake wrote:
>> THREADS.txt states that the contents of vm should not be read or
>> modified while the vm lock is not held, but that the lock must not
>> be held while performing a monitor command.  This fixes all the
>> offenders that I could find.
>>

>> @@ -2210,8 +2213,9 @@ int qemuProcessStart(virConnectPtr conn,
>>      }
>>
>>      VIR_DEBUG0("Setting initial memory amount");
>> +    cur_balloon = vm->def->mem.cur_balloon;
>>      qemuDomainObjEnterMonitorWithDriver(driver, vm);
>> -    if (qemuMonitorSetBalloon(priv->mon, vm->def->mem.cur_balloon) < 0) {
>> +    if (qemuMonitorSetBalloon(priv->mon, cur_balloon) < 0) {
>>          qemuDomainObjExitMonitorWithDriver(driver, vm);
>>          goto cleanup;
>>      }
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]