[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Detect support for HMP passthrough



On Thu, Mar 17, 2011 at 13:40:38 -0600, Eric Blake wrote:
> Do we need code in qemu_driver.c:qemuDomainMonitorCommand to make 'virsh
> qemu-monitor-command --hmp' get a nice error message when
> qemuMonitorCheckHMP fails, or is that error message already sufficient?

The error returned in this case is:

error: internal error unable to execute QEMU command 'human-monitor-command':
The command human-monitor-command has not been found

It's good enough for someone who knows what that means but not very nice for
normal end user. So I made some changes and sent v2 of this series. With that
the error is:

error: unsupported configuration: HMP passthrough is not supported by qemu
process; only QMP commands can be used

Similar thing applies to your comment in patch 2/2.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]