[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/6] Fix infinite loop in daemon if client quits with multiple streams open



On 03/18/2011 10:36 AM, Daniel P. Berrange wrote:
> The daemon loops over the linked list of streams when a client
> quits, closing any that the client hadn't already closed. Except
> it didn't ever move to the next element in the list!
> 
> * daemon/stream.c: Fix loop over linked list of streams
> ---
>  daemon/stream.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/daemon/stream.c b/daemon/stream.c
> index 967aea2..b94e3df 100644
> --- a/daemon/stream.c
> +++ b/daemon/stream.c
> @@ -343,6 +343,7 @@ remoteRemoveClientStream(struct qemud_client *client,
>                  filter->next = filter->next->next;
>                  break;
>              }
> +            filter = filter->next;

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]