[libvirt] [PATCH] rpm: require radvd when building network support

[Daniel P. Berrange]

On Wed, Mar 23, 2011 at 08:58:17AM -0600, Eric Blake wrote:
> Otherwise, attempts to use ipv6 will fail with:
> 
> error: Failed to start network ipv6net
> error: Cannot find radvd - Possibly the package isn't installed: No such file
> or directory
> 
> * libvirt.spec.in (with_network): Require radvd.
> ---
> 
> v2: also add runtime requirement, and drop junk .gnulib and with_ipv6
> cruft that snuck into v1
> 
>  libvirt.spec.in |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 4a62c80..7aa7037 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -238,6 +238,7 @@ Requires: bridge-utils
>  %if %{with_network}
>  Requires: dnsmasq >= 2.41
>  Requires: iptables
> +Requires: radvd
>  %endif

We need iptables-ipv6 there too

>  %if %{with_nwfilter}
>  Requires: ebtables
> @@ -339,6 +340,7 @@ BuildRequires: libselinux-devel
>  %endif
>  %if %{with_network}
>  BuildRequires: dnsmasq >= 2.41
> +BuildRequires: radvd
>  %endif

Do we also want  iptables/iptables-ipv6 for the same reason. Though
we have them anyway via  with_nwfilter, we should probably be explicit


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|