[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 2/2] rpm: add missing dependencies



On Wed, Mar 23, 2011 at 11:24:08AM -0600, Eric Blake wrote:
> Among others, the missing radvd dependency showed up as:
> 
> error: Failed to start network ipv6net
> error: Cannot find radvd - Possibly the package isn't installed: No such file
> or directory
> 
> even when radvd was installed, because the RADVD preprocessor
> symbol was missing at configure time.
> 
> * libvirt.spec.in (with_network): Add BuildRequires for radvd,
> iptables, and ip6tables.
> (BuildRequires): Add libxslt and augeas for docs and test.
> (with_libvirtd): Add module-init-tools for modprobe.
> (with_nwfilter): Add BuildRequires for ebtables.
> (with_esx): Fix esx build on RHEL 5, thanks to curl-devel rename.
> ---
> 
> v4: No change to patch 1/2; patch 2/2 now works on RHEL 5.
> 
>  libvirt.spec.in |   26 ++++++++++++++++++++++++--
>  1 files changed, 24 insertions(+), 2 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 4f1bdc8..6a1c022 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -236,15 +236,21 @@ Requires: %{name}-client = %{version}-%{release}
>  # daemon is present
>  %if %{with_libvirtd}
>  Requires: bridge-utils
> +# for modprobe of pci devices
> +Requires: module-init-tools
> +# for /sbin/ip
> +Requires: iproute
>  %endif
>  %if %{with_network}
>  Requires: dnsmasq >= 2.41
> +Requires: radvd
> +%endif
> +%if %{with_network} || %{with_nwfilter}
>  Requires: iptables
> +Requires: iptables-ipv6
>  %endif
>  %if %{with_nwfilter}
>  Requires: ebtables
> -Requires: iptables
> -Requires: iptables-ipv6
>  %endif
>  # needed for device enumeration
>  %if %{with_hal}
> @@ -313,10 +319,15 @@ BuildRequires: xmlrpc-c-devel >= 1.14.0
>  %endif
>  BuildRequires: libxml2-devel
>  BuildRequires: xhtml1-dtds
> +BuildRequires: libxslt
>  BuildRequires: readline-devel
>  BuildRequires: ncurses-devel
>  BuildRequires: gettext
>  BuildRequires: gnutls-devel
> +%if 0%{?fedora} >= 12 || 0%{?rhel} >= 6
> +# for augparse, optionally used in testing
> +BuildRequires: augeas
> +%endif
>  %if %{with_hal}
>  BuildRequires: hal-devel
>  %endif
> @@ -341,8 +352,15 @@ BuildRequires: libselinux-devel
>  %endif
>  %if %{with_network}
>  BuildRequires: dnsmasq >= 2.41
> +BuildRequires: iptables
> +BuildRequires: iptables-ipv6
> +BuildRequires: radvd
> +%endif
> +%if %{with_nwfilter}
> +BuildRequires: ebtables
>  %endif
>  BuildRequires: bridge-utils
> +BuildRequires: module-init-tools
>  %if %{with_sasl}
>  BuildRequires: cyrus-sasl-devel
>  %endif
> @@ -406,7 +424,11 @@ BuildRequires: libssh2-devel
>  BuildRequires: netcf-devel >= 0.1.4
>  %endif
>  %if %{with_esx}
> +%if 0%{?fedora} >= 9 || 0%{?rhel} >= 6
>  BuildRequires: libcurl-devel
> +%else
> +BuildRequires: curl-devel
> +%endif
>  %endif
>  %if %{with_audit}
>  BuildRequires: audit-libs-devel

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]