[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Make error reporting in libvirtd thread safe



On Wed, Mar 23, 2011 at 11:01:32 -0600, Eric Blake wrote:
> > diff --git a/daemon/remote.c b/daemon/remote.c
> > index a8fef4d..4b42ed2 100644
> > --- a/daemon/remote.c
> > +++ b/daemon/remote.c
> > @@ -757,8 +757,8 @@ remoteDispatchDomainGetSchedulerType (struct qemud_server *server ATTRIBUTE_UNUS
> >  
> >      type = virDomainGetSchedulerType (dom, &nparams);
> >      if (type == NULL) {
> > -        virDomainFree(dom);
> >          remoteDispatchConnError(rerr, conn);
> > +        virDomainFree(dom);
> >          return -1;
> >      }
> 
> ...and that this rearrangement is required to avoid clobbering the last
> error.
> 
> I spent time browsing remote.c for any instances you might of missed,
> and found one.

Oh, thanks for catching it. And I even went twice through the file...

I fixed that and pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]