[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix the check of the output of monitor command 'device_add'



On 03/24/2011 02:56 AM, Wen Congyang wrote:
> Hotpluging host usb device by text mode will fail, because the monitor
> command 'device_add' outputs 'husb: using...' if it succeeds, but we
> think the command should not output anything.
> 
> Signed-off-by: Wen Congyang <wency cn fujitsu com>
> 
> ---
>  src/qemu/qemu_monitor_text.c |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c
> index 91ecc8b..75b2995 100644
> --- a/src/qemu/qemu_monitor_text.c
> +++ b/src/qemu/qemu_monitor_text.c
> @@ -2283,7 +2283,15 @@ int qemuMonitorTextAddDevice(qemuMonitorPtr mon,
>          goto cleanup;
>      }
>  
> -    /* If the command succeeds, no output is sent. So
> +    /* If the host device is hotpluged first time, qemu will output
> +     * husb: using %s file-system with %s if the command succeeds.

ACK.  I was a bit surprised that qemu had a leading h, but git grep on
qemu.git confirmed this is correct.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]