[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCHv4 13/15] qemu: consolidate migration to file code



On 03/10/2011 05:16 AM, Daniel P. Berrange wrote:
> On Wed, Mar 09, 2011 at 07:18:31PM -0700, Eric Blake wrote:
>> This points out that core dumps (still) don't work for root-squash
>> NFS, since the fd is not opened correctly.  This patch should not
>> introduce any functionality change, it is just a refactoring to
>> avoid duplicated code.
>>
>> * src/qemu/qemu_driver.c (qemuDomainMigrateToFile): New function.
>> (qemudDomainSaveFlag, doCoreDump): Use it.
> 
> I think it could be worth moving this method into qemu_migrate.h/.c
> now it is decoupled from the public API objects/methods.

Agreed; and will do that for v5 coming up once my NFS testing completes.

> 
> ACK to the refactoring regardless.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]