[libvirt] [PATCH 2/2] check whether qemuMonitorJSONHMP() failed

[Daniel P. Berrange]

On Tue, Mar 29, 2011 at 05:48:48PM +0800, Wen Congyang wrote:
> If qemu quited unexpectedly when we call qemuMonitorJSONHMP(),
> libvirt will crash.
> Steps to reproduce this bug:
> 1. use gdb to attach libvirtd, and set a breakpoint in the function
>    qemuMonitorSetCapabilities()
> 2. start a vm
> 3. let the libvirtd to run until qemuMonitorJSONSetCapabilities() returns.
> 4. kill the qemu process
> 5. continue running libvirtd
> 
> Signed-off-by: Wen Congyang <wency at cn.fujitsu.com>
> 
> ---
>  src/qemu/qemu_monitor.c      |    9 ++++++++-
>  src/qemu/qemu_monitor_json.c |    9 ++++++++-
>  2 files changed, 16 insertions(+), 2 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|