[libvirt] [PATCH] Add support for DNS TXT records

Paolo Bonzini pbonzini at redhat.com
Tue Mar 29 15:12:56 UTC 2011


On 03/29/2011 05:08 PM, Michal Novotny wrote:
> Ok, however vendor-class and user-class should be used together and
> therefore it could be committed into one commit, right? The next commit
> could be the dhcp-mac one... right ?

No, they can be one patch series, but they should be separate commits.

>> Commas only in the name, please.  libvirt helpers should take care of
>> escaping quotes.
>
> What do you mean? To apply the restriction only to "name" attribute and
> not "value" attribute? I'm having it applied for both now so I'd like to
> know whether it's OK to let it this way or not :)

I'll let others chime in, but I think that if dnsmasq documents that 
"The value of TXT record is a set of strings, so any number may be 
included, split by commas" we can keep the same definition.

Paolo




More information about the libvir-list mailing list