[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] Network: Add TXT record and hosts support for DNS on virtual network



> On Wed, Mar 30, 2011 at 03:54:07PM +0200, Michal Novotny wrote:
>>> On Wed, Mar 30, 2011 at 02:57:10PM +0200, Michal Novotny wrote:
>>>> Hi,
>>>> this is the patch to introduce the TXT record support for the DNS
>>>> service on the virtual network. This can be defined using the
>>>> txt-record subelement in the dns element of the network XML
>>>> description.
>>>>
>>>> First patch is adding TXT record support to the DNS service on
>>>> the virtual network and the second patch is adding support for
>>>> defining hosts for the DNS service.
>>>>
>>>> The new definition syntax is:
>>>>
>>>>           <dns>
>>>>             <txt-record name="example name" value="example value" />
>>>>             <host ip='192.168.122.1'>
>>>>               <hostname>gateway</hostname>
>>>>               <hostname>host</hostname>
>>>>             </host>
>>>>           </dns>
>>>>
>>>> Where multiple host elements can be defined to put the aliases
>>>> for specified IP addresses.
>>>>
>>>> The patch series has been tested for the configuration and it
>>>> was working fine and also RelaxNG schema with the tests have
>>>> been both altered to add test cases to test those patches.
>>>>
>>>> Both of the patches passed make, syntax checking and all the
>>>> tests.
>>>   Principle sounds fine but let's defer this to after 0.9.0, :)
>>>
>>> Daniel
>>>
>> Oh, do you mean we not only put this to version after 0.9.0 but also we
>> add some new things to this as well?
>>
>> Is my patch good for this and will we just merge it to "after 0.9.0"
>> version or should we rewrite it entirely once it's OK? Since I don't
>> work in libvirt team maybe I won't be working on this one (unless
>> somebody ask me to do it) so based on this fact I'm not primarily
>> working in the libvirt team I may not know about whether work on this
>> one is on or not so maybe it's good if you ask me to work on this when
>> it's on or lead the assigned engineer to ask me about this.
>   Just that we are in freeze for 0.9.0, so I suggest to review and
> apply this there after, say early next week,
>
> Daniel
>
Well, that way I think it's OK and committee could simply change 0.9.0
in the formatnetwork.html.in to 0.9.1 if there are no further issues
with the patch itself and once it's ACKed :)

Michal

-- 
Michal Novotny <minovotn redhat com>, RHCE
Virtualization Team (xen userspace), Red Hat


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]