[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix media eject with qemu-0.12.*



On Wed, Mar 30, 2011 at 12:27:32 -0600, Eric Blake wrote:
> On 03/30/2011 12:16 PM, Laine Stump wrote:
> >> +++ b/bootstrap.conf
> >> @@ -63,6 +63,7 @@ sigpipe
> >>   snprintf
> >>   socket
> >>   stpcpy
> >> +strcasestr
> > 
> > Even though strcasestr is a non-standard function, you're using gnulib
> > for it, so that shouldn't be a problem. And your change will work for
> > both old and new qemus.
> 
> Technically, using c-strcasestr would be nicer than strcasestr (it
> doesn't have as many problems with multibyte characters, even though the
> particular substring we are searching for is not multibyte).  But right
> now, it's LGPLv3+ in gnulib - I've put in a request to see if we can get
> that relaxed.
> 
> Meanwhile, using strcasestr is appropriate.
> 
> > 
> > ACK.
> 
> I concur, and think this is appropriate for 0.9.0 with minimal risk if
> you push now.

Thanks, pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]