[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix several formatting mistakes in doc



On 03/31/2011 07:58 AM, Daniel P. Berrange wrote:
>>        <li>When a QEMU guest is stopped, the qemu hook script is called
>>          in two locations, to match the startup.
>>          First, <span class="since">since 0.8.0</span>, the hook is
>> -        called before libvirt restores any labels:</br>
>> +        called before libvirt restores any labels:<br/>

Oh my, showing off all my recent typos.  Sorry!

>>          <pre>/etc/libvirt/hooks/qemu guest_name stopped end -</pre>
>>          Then, after libvirt has released all resources, the hook is
>>          called again, <span class="since">since 0.9.0</span>, to allow
> 
> This exposes several problems in the docs/Makefile.am
> 
>  - make clean doesn't work in a VPATH build because
>    for some reason the HTML is generated in the $srcdir

Intentional - docs are machine independent and therefore may be
distributed, and by distributing them, others don't have to have the
tools to rebuild them.  Distributed files should generally be built in
srcdir

>    and so 'rm -f *.html' misses the files

So that's the real bug - the clean hook needs to be prefixed with $(srcdir).

> 
>  - We run xmllint, but failures in xmllint validation
>    are not causing a build failure

Yeah, I've complained about that before, but haven't done anything about
it yet.  I guess I know what I'll be doing today as followups to this :)

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]