[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: fix mingw failure on creating nonblocking pipe



On 03/31/2011 04:03 PM, Eric Blake wrote:
> * .gnulib: Update to latest, for nonblocking module.
> * bootstrap.conf (gnulib_modules): Add nonblocking.
> * src/util/util.c (virSetBlocking): Defer to gnulib.
> ---
> 
> Matthias, does this work for you on your mingw build?  So far,
> I have only tested that it cross-compiles, and that the new
> gnulib module passes its self-test when run in isolation on mingw.
> 
>  int virSetBlocking(int fd, bool blocking) {

> -    if (blocking)
> -        flags &= ~O_NONBLOCK;

> +    return set_nonblocking_flag (fd, blocking);

Oops - that _can't_ work.  s/blocking/!blocking/ in that return statement.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]