[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Make QEMU migration use cached qemu capabilities data



On 05/04/2011 07:49 AM, Daniel P. Berrange wrote:
> * src/qemu/qemu_migration.c, src/qemu/qemu_migration.h: Remove
>   qemuCaps parameters & use cached data
> * src/qemu/qemu_driver.c: Don't create & pass qemuCaps to
>   migration methods
> ---
>  src/qemu/qemu_driver.c    |   11 ++---------
>  src/qemu/qemu_migration.c |   32 ++++++--------------------------
>  src/qemu/qemu_migration.h |    1 -
>  3 files changed, 8 insertions(+), 36 deletions(-)
> 
> @@ -2296,7 +2289,7 @@ static int doCoreDump(struct qemud_driver *driver,
>          goto cleanup;
>      }
>  
> -    if (qemuMigrationToFile(driver, vm, NULL, fd, 0, path,
> +    if (qemuMigrationToFile(driver, vm, fd, 0, path,

Sweet!  This change lets core dump use fd: migration instead of always
falling back to exec: migration.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]