[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remote: avoid null dereference on error



On 05/04/2011 10:38 AM, Daniel P. Berrange wrote:
> On Tue, May 03, 2011 at 11:28:30AM -0600, Eric Blake wrote:
>> Clang found three instances of uninitialized use of nparams in
>> the cleanup path.  Unfortunately, one is a false positive: clang
>> couldn't see that ret->params.params_val is guaranteed to be
>> NULL unless allocated within a function, and that nparams is
>> guaranteed to be assigned prior to the allocation; hoisting the
>> assignment to nparams to be earlier in the function shuts up
>> that false positive.  But two of the reports also happened to
>> highlight a real bug - the error path can dereference NULL.
>>
>> * daemon/remote.c (remoteDispatchDomainGetMemoryParameters)
>> (remoteDispatchDomainGetBlkioParameters): Don't clear fields if
>> array was not allocated.
>> (remoteDispatchDomainGetSchedulerParameters): Initialize nparams
>> earlier.
>> ---
>>  daemon/remote.c |   29 ++++++++++++++++-------------
>>  1 files changed, 16 insertions(+), 13 deletions(-)
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]