[libvirt] [PATCH 00/22] Extend remote generator to generate function bodies too

Matthias Bolte matthias.bolte at googlemail.com
Thu May 5 19:55:17 UTC 2011


2011/4/24 Matthias Bolte <matthias.bolte at googlemail.com>:
> Richard W.M. Jones suggested [1] that the code that directly deals with the
> XDR protocol should be generated. The remote_generate_stubs.pl script
> already generates all the headers, just the bodies in the daemon and remote
> driver are manually written. But most of the functions just follow simple
> patterns. So I extended the generator to exploit this patterns and move
> 11 kLOC code from manually written to generated code.
>
> During this I came a cross many small variations and problems in the XDR
> protocol. For example, NWFilterDefineXML has a flags parameter in the public
> API, but it's not transferred in the XDR protocol. Another things is the
> variations in the usage of unsigned VS signed types. This comes in two forms.
> public API VS XDR procotol and in between different functions. For example,
> some functions use int for the flags paramater and some use unsigned int.
>
> This results in quite a lot of special case handling in the generator.
>

I pushed this series to gitorious for simpler review as Dan suggested:

https://gitorious.org/~photron/libvirt/photron-libvirt/commits/remotegen

Matthias




More information about the libvir-list mailing list