[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: drop files generated by config.status from tarball



On 05/06/2011 10:59 AM, Doug Goldstein wrote:
> On Fri, May 6, 2011 at 11:25 AM, Eric Blake <eblake redhat com> wrote:
>> The rule of thumb is that any file generated by config.status
>> is a) reproducible by any user, b) dependent on configure options.
>> Therefore, it is inappropriate to include such generated files
>> in the tarball (for proof, Makefile is generated from Makefile.in;
>> the former is not in the tarball while the latter is).
>>
>> * Makefile.am (EXTRA_DIST): Remove files covered by AC_OUTPUT.
>> ---
>>
>> Tested with 'make distcheck'.
> 
> ACK, this patch is correct to achieve the desired results.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]