[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/6 V3] inject-nmi: Implementing the remote protocol



On Thu, Apr 21, 2011 at 02:43:01PM +0800, Lai Jiangshan wrote:
> 
> 
> Signed-off-by: Lai Jiangshan <laijs cn fujitsu com>
> ---
>  daemon/remote.c                     |   28 ++++++++++++++++++++++++++++
>  daemon/remote_dispatch_args.h       |    1 +
>  daemon/remote_dispatch_prototypes.h |    8 ++++++++
>  daemon/remote_dispatch_table.h      |    5 +++++
>  src/remote/remote_driver.c          |   26 +++++++++++++++++++++++++-
>  src/remote/remote_protocol.c        |   11 +++++++++++
>  src/remote/remote_protocol.h        |   10 ++++++++++

All these changes can be deleted, since Matthias' RPC generator
code will trivially cope with virDomainInjectNMI.

>  src/remote/remote_protocol.x        |    8 +++++++-
>  src/remote_protocol-structs         |    4 ++++
>  9 files changed, 99 insertions(+), 2 deletions(-)

So want these two files only in GIT.


> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index 675eccd..1aacf99 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -817,6 +817,11 @@ struct remote_domain_undefine_args {
>      remote_nonnull_domain dom;
>  };
>  
> +struct remote_domain_inject_nmi_args {
> +    remote_nonnull_domain dom;
> +    unsigned int flags;
> +};
> +
>  struct remote_domain_set_vcpus_args {
>      remote_nonnull_domain dom;
>      int nvcpus;
> @@ -2176,8 +2181,9 @@ enum remote_procedure {
>      REMOTE_PROC_DOMAIN_GET_BLKIO_PARAMETERS = 206,
>      REMOTE_PROC_DOMAIN_MIGRATE_SET_MAX_SPEED = 207,
>      REMOTE_PROC_STORAGE_VOL_UPLOAD = 208,
> -    REMOTE_PROC_STORAGE_VOL_DOWNLOAD = 209
> +    REMOTE_PROC_STORAGE_VOL_DOWNLOAD = 209,
>  
> +    REMOTE_PROC_DOMAIN_INJECT_NMI = 210,
>      /*
>       * Notice how the entries are grouped in sets of 10 ?
>       * Nice isn't it. Please keep it this way when adding more.
> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index 944553c..4b75e33 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -1435,3 +1435,7 @@ struct remote_message_header {
>          u_int                      serial;
>          remote_message_status      status;
>  };
> +struct remote_domain_inject_nmi_args {
> +        remote_nonnull_domain      dom;
> +        unsigned int               flags;
> +};

ACK to these parts


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]