[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Magic error introduced by commit f09accc



On 05/09/2011 03:05 AM, Jiri Denemark wrote:
>> work around the issue by doing:
>>
>> #define inline
>> #include <netlink/msg.h>
>> #undef inline
>>
>> in src/util/macvtap.c.
>>
> I think we shouldn't do this.
> 
>> In one regards, the only people that ever run into this are those that are
>> using incompatible self-built gcc and libnl (Jirka was testing on a gentoo
>> system), and we're doing the user a favor to have them patch their libnl
>> headers rather than making libvirt work around it.  Most distros (including
>> RHEL 5, which stands as the current litmus test of how much workarounds we
>> have to support in libvirt) have already patched the header

I stand corrected - Ubuntu is also affected:
https://bugs.launchpad.net/ubuntu/+source/libnl/+bug/780044

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]