[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/6 V4] inject-nmi: Implementing the public API



On 05/10/2011 02:26 AM, Lai Jiangshan wrote:
> ---
>  src/libvirt.c |   44 ++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 44 insertions(+), 0 deletions(-)
> 
> diff --git a/src/libvirt.c b/src/libvirt.c
> index abacf85..f468b61 100644
> --- a/src/libvirt.c
> +++ b/src/libvirt.c
> @@ -5217,6 +5217,50 @@ error:
>  }
>  
>  /**
> + * virDomainInjectNMI:
> + * @domain: pointer to domain object, or NULL for Domain0
> + * @flags:  the flags for controlling behaviours

s/behaviours/behavior, pass 0 for now/

> +    if (!VIR_IS_CONNECTED_DOMAIN(domain)) {
> +        virLibDomainError(VIR_ERR_INVALID_DOMAIN, __FUNCTION__);
> +        virDispatchError(NULL);
> +        return (-1);

No need for extra () on return.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]