[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: avoid crash when run under gcov



On 05/11/2011 09:57 AM, Eric Blake wrote:
> Running ./autobuild.sh failed when gcov is installed, because
> commandtest ended up crashing during gcov's getenv() call after
> exit() had already started.  I traced this nasty bug back to
> a scoping issue present since the test introduction.
> 
> * tests/commandtest.c (mymain): Move newenv...
> (newenv): ...to a scope that is still useful during exit().

P.S. I think that's a bug in gcov for calling getenv("GCOV_PREFIX")
multiple times during the program.  Since the program can change it's
own environment, gcov should only be calling getenv() once during
startup and caching the results for the life of the program.  So I filed:

https://bugzilla.redhat.com/show_bug.cgi?id=703919

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]