[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 6/8] virFDStream: Add option for delete file after it's opening



On 05/13/2011 03:18 AM, Daniel P. Berrange wrote:
> On Thu, May 12, 2011 at 06:29:13PM +0200, Michal Privoznik wrote:
>> This is needed if we want to transfer a temporary file. If the
>> transfer is done with iohelper, we might run into a race condition,
>> where we unlink() file before iohelper is executed.
>>
>> * src/fdstream.c, src/fdstream.h,
>>   src/util/iohelper.c: Add new option
>> * src/lxc/lxc_driver.c, src/qemu/qemu_driver.c,
>>   src/storage/storage_driver.c, src/uml/uml_driver.c,
>>   src/xen/xen_driver.c: Expand existing function calls

I still think it would be nice to have a mode where iohelper receives
its fd by inheritance, rather than having to call open() again.  But
that's not a show-stopper for pushing this.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]