[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] test: all test_scripts should be part of tarball when building without libvirtd



At 2011-5-13 17:37, Daniel P. Berrange write:
On Fri, May 13, 2011 at 04:03:20PM +0800, Wen Congyang wrote:
Steps to reproduce this problem:
1. # ./autogen.sh --without-libvirtd
2. # make dist
3. # rpmbuild --nodeps --define "_sourcedir `pwd`" -ba libvirt.spec
    ...
    make  check-TESTS
    make[1]: Entering directory `/home/wency/rpmbuild/BUILD/libvirt-0.9.1/tests'
    make[1]: *** No rule to make target `test_conf.sh', needed by `check-TESTS'.  Stop.
    make[1]: Leaving directory `/home/wency/rpmbuild/BUILD/libvirt-0.9.1/tests'
    make: *** [check-am] Error 2
    error: Bad exit status from /var/tmp/rpm-tmp.7Rb9PV (%check)

---
  tests/Makefile.am |   18 ++++++++++++++++++
  1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index fe191fd..bc171d2 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -144,6 +144,24 @@ test_scripts +=				\
  	virsh-optparse			\
  	virsh-schedinfo			\
  	virsh-synopsis
+else
+EXTRA_DIST += 				\
+	test_conf.sh			\
+	cpuset				\
+	daemon-conf			\
+	define-dev-segfault		\
+	int-overflow			\
+	libvirtd-fail			\
+	libvirtd-pool			\
+	read-bufsiz			\
+	read-non-seekable		\
+	start				\
+	undefine			\
+	vcpupin				\
+	virsh-all			\
+	virsh-optparse			\
+	virsh-schedinfo			\
+	virsh-synopsis
  endif

ACK

Thanks, pushed.


Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]